Add csharp customizations for Monitor migration#43812
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
Monitor
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use named legacy extension operations and C# client names so data collection rule associations and diagnostic settings keep the GA Azure.ResourceManager.Monitor resource names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add CSharp customizations for resource data, collection, action group, notification, data collection, autoscale, and scheduled query rule names to preserve more of the shipped Azure.ResourceManager.Monitor API surface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add additional CSharp names and alternate types for Monitor resource data, notification, autoscale, data collection, and scheduled query rule compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Model private link resources with PrivateLinks over the PrivateLinkScope parent instead of declaring PrivateLinkResource as a child ARM resource. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add csharp to AlertSeverity clientName decorators so generated values use Zero through Four. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Apply TypeSpec formatting and address warn-as-error diagnostics from the Monitor validation pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep DataCollectionApi TypeSpec and generated swagger output in sync for TypeSpec validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add intentional Monitor CSharp compatibility names to the Monitor spellcheck word list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
ARMReview
WaitForARMFeedback
ravimeda
reviewed
Jun 24, 2026
ravimeda
left a comment
ravimeda
left a comment
Member
There was a problem hiding this comment.
ARM API Review
Posting findings from the ARM API Reviewer agent (critic-verified, 1 iteration, converged) against commit 774bcfe. See the inline comment for the Warning finding. A second finding (an [EXISTING] cross-file suppression suggestion) is posted as a top-level PR comment because the cited lines fall outside this PR's diff.
Member
|
[EXISTING] 🔵 Suggestion [typespec-review §4.1] Locations:
Classification reasoning: Pre-existing — identical FIXME placeholders exist on the base commit; not introduced by this PR. Flagged because this PR edits the very constructs these suppressions are attached to. Issue: These suppression reasons read Suggested fix: Since these operations/aliases are being modified anyway, consider replacing the FIXME placeholders with real technical justifications for the Posted as a top-level comment because the cited suppression lines fall outside this PR's diff hunks and span two files. |
ravimeda
added
ARMChangesRequested
and removed
WaitForARMFeedback
Add Monitor-specific CSharp client names for generic NSP, metrics, incident, and data collection generated surfaces requested in SDK review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Map remaining Monitor identity properties to common ManagedServiceIdentity for CSharp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename generated alert rule incident model to the shipped MonitorIncident name for CSharp compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Map resource IDs, URIs, and Azure locations to SDK-friendly CSharp types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add CSharp client names for remaining generic Monitor models and NSP parent types from SDK review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Expand NSP operation names and add Monitor context to NSP data and incident receiver CSharp names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add CSharp client names for remaining review feedback on Monitor model naming. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mark metrics list GET operations pageable for CSharp to match the shipped SDK surface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit 955212c.
ArthurMa1978
approved these changes
Jun 30, 2026
ArthurMa1978
added
Approved-Avocado
PublishToCustomers
github-actions
Bot
added
ARMAutoSignedOff-IncrementalTSP
and removed
ARMChangesRequested
labels
Member
|
This PR updates the settings for the .NET SDK release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
ModelReaderWriterContextDefinitioninitializer crash; see SDK migration logs for details.